I realized that some files are missing in this patch set. I will fix it and share it again. Thanks, Jeonghwan Yoon. -----Original Message----- From: Jouni Malinen [mailto:j@xxxxx] Sent: Monday, December 03, 2018 7:43 AM To: Jeonghwan Yoon Cc: hostap@xxxxxxxxxxxxxxxxxxx; hg.cho@xxxxxxx; youngjun4724.jo@xxxxxxx; taesung.lim@xxxxxxx; byungjoo.lee@xxxxxxx Subject: Re: [PATCH 1/3] dbus: Enabled dpp functions Is this patchset missing some other changes? The combination of these three patches has following changes: doc/dbus.doxygen | 294 ++++++++++++++++ wpa_supplicant/dbus/dbus_new.c | 574 ++++++++++++++++++++++++++++++++ wpa_supplicant/dbus/dbus_new.h | 105 +++++ wpa_supplicant/dbus/dbus_new_handlers.c | 185 ++++++++++ wpa_supplicant/dbus/dbus_new_handlers.h | 18 + 5 files changed, 1176 insertions(+) This does not compile and is most likely missing calls from wpa_supplicant/notify.c or some other wpa_supplicant directory files. For example: dbus/dbus_new_handlers.c: In function ‘wpas_dbus_handler_dpp_configurator_params’: dbus/dbus_new_handlers.c:4899:8: error: implicit declaration of function ‘wpa_supplicant_ctrl_iface_process’ [-Werror=implicit-function-declaration] res = wpa_supplicant_ctrl_iface_process(wpa_s, cmd_buf, &resp_len); ^ dbus/dbus_new_handlers.c:4899:6: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] res = wpa_supplicant_ctrl_iface_process(wpa_s, cmd_buf, &resp_len); ^ dbus/dbus_new_handlers.c:4890:18: error: unused variable ‘iter’ [-Werror=unused-variable] DBusMessageIter iter; ^ dbus/dbus_new_handlers.c: In function ‘wpas_dbus_handler_dpp_bootstrap_gen’: dbus/dbus_new_handlers.c:4922:7: error: implicit declaration of function ‘wpas_dpp_bootstrap_gen’ [-Werror=implicit-function-declaration] id = wpas_dpp_bootstrap_gen(wpa_s, type); ^ dbus/dbus_new_handlers.c: In function ‘wpas_dbus_handler_dpp_bootstrap_remove’: dbus/dbus_new_handlers.c:4947:11: error: implicit declaration of function ‘wpas_dpp_bootstrap_remove’ [-Werror=implicit-function-declaration] result = wpas_dpp_bootstrap_remove(wpa_s, id); ^ dbus/dbus_new_handlers.c: In function ‘wpas_dbus_handler_dpp_pkex_add’: dbus/dbus_new_handlers.c:4972:11: error: implicit declaration of function ‘wpas_dpp_pkex_add’ [-Werror=implicit-function-declaration] result = wpas_dpp_pkex_add(wpa_s, cmd); ^ dbus/dbus_new_handlers.c: In function ‘wpas_dbus_handler_dpp_pkex_remove’: dbus/dbus_new_handlers.c:4997:11: error: implicit declaration of function ‘wpas_dpp_pkex_remove’ [-Werror=implicit-function-declaration] result = wpas_dpp_pkex_remove(wpa_s, id); ^ dbus/dbus_new_handlers.c: In function ‘wpas_dbus_handler_dpp_listen’: dbus/dbus_new_handlers.c:5023:11: error: implicit declaration of function ‘wpas_dpp_listen’ [-Werror=implicit-function-declaration] result = wpas_dpp_listen(wpa_s, cmd); ^ dbus/dbus_new_handlers.c:5016:18: error: unused variable ‘iter’ [-Werror=unused-variable] DBusMessageIter iter; ^ dbus/dbus_new_handlers.c: In function ‘wpas_dbus_handler_dpp_listen_stop’: dbus/dbus_new_handlers.c:5041:2: error: implicit declaration of function ‘wpas_dpp_stop’ [-Werror=implicit-function-declaration] wpas_dpp_stop(wpa_s); ^ dbus/dbus_new_handlers.c:5042:2: error: implicit declaration of function ‘wpas_dpp_listen_stop’ [-Werror=implicit-function-declaration] wpas_dpp_listen_stop(wpa_s); ^ dbus/dbus_new_handlers.c: In function ‘wpas_dbus_handler_dpp_configurator_add’: dbus/dbus_new_handlers.c:5054:11: error: implicit declaration of function ‘wpas_dpp_configurator_add’ [-Werror=implicit-function-declaration] result = wpas_dpp_configurator_add(wpa_s, cmd); ^ -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
