Re: [PATCH 1/6] Add a header file defining Intel Lantiq OUI and vendor extensions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 26, 2018 at 03:02:41PM +0530, Sarada Prasanna Garnayak wrote:
> This file is used as a registry of identifier assignments from the
> Intel Lantiq OUI 00:13:74 for purposes other than MAC address assignment.
> This file adds support for the Intel Lantiq WLAN module configuration
> and management using nl80211 vendor commands/events.

00:13:74 is not an Intel Lantiq OUI.. The commit message should be fixed
to talk about the correct OUI.

> diff --git a/src/common/intel-ltq-vendor.h b/src/common/intel-ltq-vendor.h
> @@ -0,0 +1,71 @@
> +/*
> + * Intel Lantiq OUI and vendor specific assignments.
> + * Copyright (c) 2018 The Linux Foundation. All rights reserved.
> + *
> + * Permission to use, copy, modify, and/or distribute this software for any
> + * purpose with or without fee is hereby granted, provided that the above
> + * copyright notice and this permission notice appear in all copies.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
> + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
> + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
> + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
> + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
> + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
> + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
> + *
> + * This software may be distributed under the terms of the BSD license.
> + * See README for more details.
> + */

Could you please clarify what exactly this combination of licensing
terms is supposed to mean? This looks like the ISC License followed by a
claim that the BSD license may be used for distribution. Are you
implying that either license can be used? Would you be fine with
following the same style as most of the files in hostap.git are using
(i.e., just those last two lines)? Or at least least something that is
clearly identifying a single license to use if it is compatible with the
BSD license terms?

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux