On Mon, Nov 19, 2018 at 11:14:35AM +0100, Arnout Vandecappelle wrote: > > > On 03/10/2018 03:34, Igor Mitsyanko wrote: > > + if (wps->wps->registrar->wps_cred_processing_easymesh && > > + wps->peer_dev.easymesh_ext == EASYMESH_BACKHAUL_STA && > > + wps->wps->easymesh_backhaul_ap_settings) > > + return wps_build_easymesh_backhual_ap_settings(wps, msg); > > Since the easymesh_backhaul_ap_settings file *must* exist if > wps_cred_processing_easymesh == 1, I don't think it makes sense to have two > separate config options for them. Just have one config option pointing to the > backhaul settings file. > > Note that the current Multi-AP specification implies that the backhaul BSS is > present on the same device, so we could derive the backhaul AP settings from the > hostapd configuration of that BSS. However, this might be a different hostapd > instance on a different radio, so it's not possible in general to work that way. I don't see how this would work with a hardcoded external file. The MAC Address attribute within the Credential attribute is supposed to contain the Enrollee's MAC address. The external entity generating this hardcoded file cannot know that beforehand and the same payload cannot be used with different Enrollees. It would likely make most sense to provide means for configuring the parameter values needed to allow hostapd to build the backhaul AP credential. For example, point to an interface within the same hostapd process (if that case is used) or alternatively, provide means for setting the SSID/passphrase/PSK (or whatever the exact details are) for an ESS that is not controlled by the same hostapd process. I used similar design for OWE transition mode (see owe_transition_* parameters in hostapd/hostapd.conf), but I have no issues with this being limited to only that latter alternative (i.e., new parameters to provide the needed data to construct the Credential regardless of whether the other BSS is operated by this hostapd instance) to keep implementation simpler. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
