On 18/11/2018 23:30, Jouni Malinen wrote: > On Tue, Oct 02, 2018 at 06:34:14PM -0700, Igor Mitsyanko wrote: >> This patch adds a feature similar to the existing “Additional >> Credential attribute(s)” (extra_cred), relating to the requirements of >> Wi-Fi Alliance Multi-AP Specification v1.0 (WFA EasyMesh). These specs >> can be found at https://www.wi-fi.org/file/multi-ap-specification-v10. >> >> They mandate that a “fronthaul” BSS, that is pairing a client that has >> bit 7 of the Multi-AP Extension subelement in the Wi-Fi Alliance Vendor >> Extension attribute in the WSC M1 message, shall configure such client >> with credentials pertaining to the “backhaul” BSS. Therefore we introduce >> two new configuration options (wps_cred_processing_easymesh and >> easymesh_backhaul_ap_settings) that behave like the existing extra_cred, >> except for the additional check on the content of M1. >> >> Configuring these options will be done by a “MultiAP Agent”, an open-source >> implementation of such agent is work in progress at >> https://github.com/prplfoundation/prplMesh. > > Thanks for this and the later patch for wpa_supplicant. Unfortunately, I > have been inconveniently busy with other projects and travel for a while > and have not been able to review this earlier and coordinate with other > development efforts in this area. > > I had couple of other patches waiting for review and sending out to the > list, but those got delayed as well. It would be good to see what kind > of combination of functionality from this set of patches would be best > for moving ahead with the Multi-AP functionality. The relevant patches > are here: > > http://patchwork.ozlabs.org/patch/978101/ > http://patchwork.ozlabs.org/patch/999135/ > > http://patchwork.ozlabs.org/patch/999588/ > http://patchwork.ozlabs.org/patch/999587/ > > I'll try to go these in more detail over the coming week, so any > comments would be welcome. Based on a very quick review, there is some > common functionality and some additional functionality in each set, so > some kind of merge of the patches could be needed. It sure looks like that. In particular, the hostapd.conf options are too much overlapping I think. > >> diff --git a/hostapd/config_file.c b/hostapd/config_file.c > >> + } else if (os_strcmp(buf, "easymesh_backhaul_ap_settings") == 0) { >> + os_free(bss->easymesh_backhaul_ap_settings); > > As a quick comment on naming of the functionality, I'm somewhat hesitant > on using "EasyMesh" taken into account it being the name that WFA seems > to be explicitly trademarking as part of the certification program name. > Instead, I would follow the approach used in other cases of WFA > programs, i.e., using the name of the technical specification > (Multi-AP) in the implementation. I agree with that, using multi_ap everywhere would be better. Jouni, will you be working on combining the patches in a single series? Regards, Arnout _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
