> This breaks inside-VM testing where sudo is a dummy script (see > tests/hwsim/inside.sh generating the sudo scripts). In addition, sudo is > documented to relay signals. Could you please clarify what you are trying to fix > here? Indeed the documentation of sudo says that the signals supposed to be relayed, but on some of our machines it doesn't happen. I didn't really managed to understand why. As the result ap_config_reload and ap_config_reload_file tests were failing. I missed the part regarding the VM, I guess the simple solution is just to tell the start.sh that it runs inside a VM. I'll re-send a fixed version. > > That $VALGRIND_HAPD part could be a yet another program in the chain, so it > might make more sense to to determine the actual hostapd PID through a new > test command on the control interface to make this more robust. I tested it with valgrind and it works. Instead of adding a new command, I tried to use an existing "-P" option, so hostapd would write a pid file itself. The problem here is that it requires also "-B" option, which changes the current working directory and this causes other failures. So at the end I ended up with more changes, which are probably an overkill for this. Andrei > > -- > Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
