On Thu, 2018-10-11 at 22:41 +0200, Karol Babioch wrote:
> On Linux this flag will make sure that no file descriptor is accidentally
> leaked into potential child processes. While this is not a problem right now,
> it is considered to be good practice these days when dealing with file
> descriptors on the Linux.
>
> Signed-off-by: Karol Babioch <karol@xxxxxxxxxx>
> ---
> src/utils/wpa_debug.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/src/utils/wpa_debug.c b/src/utils/wpa_debug.c
> index b412f88e3..9d159632d 100644
> --- a/src/utils/wpa_debug.c
> +++ b/src/utils/wpa_debug.c
> @@ -60,6 +60,9 @@ static int wpa_to_android_level(int level)
> #ifdef CONFIG_DEBUG_FILE
> #include <sys/types.h>
> #include <sys/stat.h>
> +#ifdef __linux__
> +#include <fcntl.h>
> +#endif /* __linux__ */
>
> static int out_fd = -1;
> static FILE *out_file = NULL;
> @@ -567,6 +570,14 @@ int wpa_debug_open_file(const char *path)
> return -1;
> }
>
> +#ifdef __linux__
> + if (fcntl(out_fd, F_SETFD, FD_CLOEXEC) == -1) {
> + wpa_printf(MSG_ERROR, "wpa_debug_open_file: Failed to set O_CLOEXEC "
> + "on output file descriptor, using standard output");
I'd argue you should just fall back to the old behaviour in the unlikely
even this fails, rather than closing the FD?
johannes
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
