On Sun, Aug 26, 2018 at 08:45:02PM +0300, Andrei Otcheretianski wrote:
> OCE shouldn't be enabled in these cases.
Why?
> diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c
> @@ -5670,7 +5670,14 @@ static int wpa_supplicant_init_iface(struct wpa_supplicant *wpa_s,
> hs20_init(wpa_s);
> #endif /* CONFIG_HS20 */
> #ifdef CONFIG_MBO
> - if (wpa_s->conf->oce) {
> + if (wpa_s->conf->oce
> +#ifdef CONFIG_P2P
> + && wpa_s->p2p_group_interface == NOT_P2P_GROUP_INTERFACE
> +#endif /* CONFIG_P2P */
> +#ifdef CONFIG_AP
> + && !wpa_s->ap_iface
> +#endif
> + ) {
> if ((wpa_s->conf->oce & OCE_STA) &&
> (wpa_s->drv_flags & WPA_DRIVER_FLAGS_OCE_STA))
> wpa_s->enable_oce = OCE_STA;
Please note that this is followed by code checking for OCE_STA_CFON and
that STA-CFON case would include "mobile AP" and P2P GO support.. Sure,
that is not yet supported, but this change in the implementation would
make the source look pretty odd..
--
Jouni Malinen PGP id EFC895FA
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
