On Mon, Jun 25, 2018 at 10:28:50PM +0200, Jouke Witteveen wrote: > One typo and one peculiar update loop. Thanks, applied. > I came accross one typo, which had survived over four years, and one odd > loop in which a variable was updated at every iteration. If you dislike > how I refactored the loop, feel free to kick that part of the patch out. That loop part should certainly be in a separate patch, so I dropped it from here to have a clean commit for fixing a real issue. The loop could be handled separately, but I'm not really sure I'd do that with the particular changes here (especially moving pos[0] setting to be after the loop and having to initialize pos to buf + 2). I don't see any real harm in the current implementation either, so I don't think I'd spend much time in trying to optimize this. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
