Re: [PATCH 2/2] dbus: Add FILS capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 08, 2018 at 12:57:20PM +0900, Masashi Honma wrote:
> diff --git a/wpa_supplicant/dbus/dbus_new_handlers.c b/wpa_supplicant/dbus/dbus_new_handlers.c
> @@ -980,7 +980,7 @@ dbus_bool_t wpas_dbus_getter_global_capabilities(
>  	const struct wpa_dbus_property_desc *property_desc,
>  	DBusMessageIter *iter, DBusError *error, void *user_data)
>  {
> -	const char *capabilities[5] = { NULL, NULL, NULL, NULL, NULL };
> +	const char *capabilities[6] = { NULL, NULL, NULL, NULL, NULL, NULL };
>  	size_t num_items = 0;
>  
>  #ifdef CONFIG_AP
> @@ -998,6 +998,9 @@ dbus_bool_t wpas_dbus_getter_global_capabilities(
>  #ifdef CONFIG_IEEE80211W
>  	capabilities[num_items++] = "pmf";
>  #endif /* CONFIG_IEEE80211W */
> +#ifdef CONFIG_FILS
> +	capabilities[num_items++] = "fils";
> +#endif /* CONFIG_FILS */

This would claim FILS to be supported even if the driver does not
support it. This should be done similarly to the "GET_CAPABILITY fils"
on the control interface, i.e., by checking the wpa_s->drv_flags. It
should also be noted that there is separate capabilities for FILS shared
key with and without PFS support (see wpa_is_fils_sk_pfs_supported()).
 
-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux