On Tue, Sep 12, 2017 at 02:09:34PM +0000, Grosmanis, Andrejs wrote: > Please ignore the previous patch because of truncation due to size of the patch. Attached is the archived patch. Please comment, or review. It would be useful if such a large patch could be split into smaller patches each doing a smaller logical step at the time.. The patch is missing commit log describing why the changes are done and Signed-off-by: line showing explicit acknowledgment of the contribution expectations (see the top level CONTRIBUTIONS file for details). I cannot apply this without those. As far as the changes are concerned, you should never modify the src/drivers/nl80211_copy.h file in a hostap.git commit. Such changes need to be first accepted into the upstream Linux kernel and I'll pull them from there when needed. I don't really like the use of bitfields for defining data structures for information sent over the air. These are painful with different byte/bit endianness and it is usually clearer to explicitly define structs with u8 array and/or le16/le32/le64 and use explicit byteorder conversion when reading/writing. Could you please explain why this patch replaces the already existing configuration interface for 802.11ax with something different? Please also note that P802.11ax/D1.4 is available and has modifications to the information element contents. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap