On 08-05-17 17:28, Jouni Malinen wrote:
> On Thu, Apr 06, 2017 at 02:50:49PM +0200, Jaap Keuter wrote:
>> The Algorithm Agility parameter value 00-80-C2-01 is corrected to
>> IEEE 802.1X-2010 in IEEE 802.1Xbx-2014. Change the identifier to
>> reflect this correction.
>
>> diff --git a/src/pae/ieee802_1x_kay.c b/src/pae/ieee802_1x_kay.c
>> @@ -32,8 +32,9 @@
>> /* IEEE Std 802.1X-2010, Table 9-1 - MKA Algorithm Agility */
>> -#define MKA_ALGO_AGILITY_2009 { 0x00, 0x80, 0xC2, 0x01 }
>> -static u8 mka_algo_agility[4] = MKA_ALGO_AGILITY_2009;
>> +/* IEEE Std 802.1Xbx-2014, Table 9-1 - MKA Algorithm Agility */
>> +#define MKA_ALGO_AGILITY_2010 { 0x00, 0x80, 0xC2, 0x01 }
>> +static u8 mka_algo_agility[4] = MKA_ALGO_AGILITY_2010;
>
> So this does not really change anything in practice since the actual
> value of mka_algo_agility[] remains identical and all that changes is
> that editorial change for the publication year of the 802.1X standard
> which happened to be used here in the define name.
>
> Why is this needed? This would be the first reference to IEEE Std
> 802.1Xbx-2014 in the implementation and I don't really see the need for
> this unless there is goal to make a more complete review of the impact
> of 802.1Xbx-2014 on the implementation.
>
Fair enough. With this first patch I was 'testing the waters', so to speak. You
may drop this patch.
Thanks,
Jaap
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
