On Thu, Mar 23, 2017 at 12:57:23PM +0100, Michael Braun wrote: > Signed-off-by: Michael Braun <michael-dev@xxxxxxxxxxxxx> > --- > src/ap/wpa_auth_ft.c | 6 ++++++ > tests/hwsim/test_ap_ft.py | 49 ++++++++++++++++++++++++++++++++++------------- Do those wpa_auth_ft.c changes really belong into this patch 7/7? All tests/hwsim/* patches should really include changes only to the test scripts or configuration; all changes to hostapd/wpa_supplicant source code need to be in their own commits. > diff --git a/src/ap/wpa_auth_ft.c b/src/ap/wpa_auth_ft.c > index 4d3a9ef..7305c7d 100644 > --- a/src/ap/wpa_auth_ft.c > +++ b/src/ap/wpa_auth_ft.c > @@ -1181,6 +1181,9 @@ wpa_ft_rrb_add_r0kh(struct wpa_authenticator *wpa_auth, > eloop_register_timeout(timeout, 0, wpa_ft_rrb_del_r0kh, > wpa_auth, r0kh); > > + if (wpa_ft_rrb_init_r0kh_seq(r0kh) < 0) > + return NULL; > + > return r0kh; > } > > @@ -1245,6 +1248,9 @@ wpa_ft_rrb_add_r1kh(struct wpa_authenticator *wpa_auth, > eloop_register_timeout(timeout, 0, wpa_ft_rrb_del_r1kh, > wpa_auth, r1kh); > > + if (wpa_ft_rrb_init_r1kh_seq(r1kh) < 0) > + return NULL; > + > return r1kh; > } In other words, were these forgotten from some of the earlier patches in this series or should these be on their own patch file? -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
