Re: [PATCH 4] Change the default value of wmm_enabled to 0 as WMM is now required to be explicitly enabled with HT/VHT/HE.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 25, 2017 at 03:15:39PM +0000, Nick Lowe wrote:
> Change the default value of wmm_enabled to 0 as WMM is now required to
> be explicitly enabled with HT/VHT/HE.

> - /* Set to -1 as defaults depends on HT in setup */
> - bss->wmm_enabled = -1;
> + bss->wmm_enabled = 0;

It would be simpler to just delete this line completely rather than add
clearing of memory that is anyway initiated to zero.. Anyway, this in
combination with the earlier patch checking that wmm_enabled is set for
HT/VHT/HE would break large number of existing configurations. I'm not
going to apply this. The current behavior seems fine to me; no need to
force everyone change their configuration to add wmm_enabled=1
explicitly.
 
-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux