Re: [PATCH] mka: Some bug fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sure.. will do this.

Thanks,
Badrish

On Sat, Dec 24, 2016 at 5:02 PM, Jouni Malinen <j@xxxxx> wrote:
> On Mon, Dec 12, 2016 at 06:27:08PM +0530, Badrish Adiga H R wrote:
>> Actually, I am using a patch which allows to configure MKA actor
>> priority. I have submitted that patch also to hostap's mailing list.
>> The test scenario is this. I have 2 peers running MACsec in PSK mode,
>> Peer A with MAC address higher than MAC Address of peer B.
>> 1. Peer B starts with actor_priority 255
>> 2. Peer A starts with priority 16, becomes key server.
>> 3. Peer A stops..
>> 4. Peer A restarts with priority 255, but because of the stale values
>> participant->is_key_server(=TRUE) and participant->is_elected(=TRUE)
>> it continues to remain as Key Server.
>> 5. For peer B, key server election happens and since it has lower MAC
>> address as compared to MAC address of A, it becomes the key server.
>>
>> Now we have 2 key servers in CA and is not correct.
>
> It would be good to get such details included in the commit message.
> Please split the changes into separate patches that each address a
> single independent issue and include the relevant description in the
> commit message.
>
> --
> Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux