On Fri, Dec 09, 2016 at 08:00:24PM +0530, Bipin Kumar wrote: > diff --git a/wpa_supplicant/ctrl_iface_named_pipe.c b/wpa_supplicant/ctrl_iface_named_pipe.c > @@ -392,10 +392,10 @@ static int ctrl_iface_parse(struct ctrl_iface_priv *priv, const char *params) > sddl = os_strstr(params, " SDDL="); > if (sddl) > sddl += 6; > + else > + return 0; > } > > - if (!sddl) > - return 0; Could you please explain why you would like to change this and how that existing check would be redundant? This patch is just moving the check to another place, not removing redundant code.. The existing implementation looks correct and clearer that what would be there with this patch applied. This function has multiple ways of setting the sddl pointer and this existing check at the end verifies all those cases. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
