From: Rafał Miłecki <rafal@xxxxxxxxxx> This reverts commit 647862eb60c324015ea31293cc052558b5185ca4. The second check of device_ap_sme looks like duplicated, but it isn't actually. The trick is nl80211_create_monitor_interface may change that variable value and the second evaluation may give a different result. This definitely isn't a very clear code, but that change caused a regression for drivers that: 1) Don't report NL80211_ATTR_DEVICE_AP_SME 2) Don't support monitor mode 3) Don't support subscribing for PROBE_REQ and/or ACTION frames like brcmfmac. With such drivers hostapd doesn't start anymore. Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> --- src/drivers/driver_nl80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index 8d43c69..24154b9 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -4434,7 +4434,8 @@ static int nl80211_setup_ap(struct i802_bss *bss) "nl80211: Failed to subscribe for mgmt frames from SME driver - trying to run without it"); if (!drv->device_ap_sme && drv->use_monitor && - nl80211_create_monitor_interface(drv)) + nl80211_create_monitor_interface(drv) && + !drv->device_ap_sme) return -1; if (drv->device_ap_sme && -- 2.9.3 _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
