On Tue, May 24, 2016 at 02:02:33PM +0300, Jonathan Afek wrote: > The regular hwsim tests use both unicast and broadcast frames to test > the connectivity between 2 interfaces. > For real hardware (remote hwsim tests) the broadcast frames will > sometimes not be seen by all connected stations since they can be in > low power mode during DTIM or because broadcast frames are not > acked. > Use 10 retries for broadcast connectivity tests for real hardware > so that the test will pass if we successfully received 1 of them. How was this tested? > + for i in xrange(broadcast_retry_c): That gives i values 0..0 or 0..9 depending on local vs. remote. > + except Exception as e: > + if i == broadcast_retry_c: i would never have value broadcast_retry_c here.. > + except Exception as e: > + if i == broadcast_retry_c: > + raise Same here. I'll fix this to use broadcast_retry_c - 1. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap