On Mon, Apr 25, 2016 at 11:14:12AM +0200, Janusz Dziedzic wrote:
> I also remove for_each() from wpa_supplicant_update_channel_list()
> while this function will be called now for each interface.
> So, seems this for_each() was a workaround for a real issue (not
> sending this message to all ifaces).
Please see commit 0f4bccdbbe642fc620d2b70f60c8ddc4ad09a5db ('Refactor
channel list update event in wpa_supplicant'). That dl_list_for_each()
in wpa_supplicant_update_channel_list() would seem to be needed to call
wpas_p2p_update_channel_list() at the end of the updates. The changes
you are proposing in this patch would seem to undo at least parts of
that earlier fix. As such, I'm not really keen on applying this without
much clearer justification on this fixing something. In other words, I'd
much rather use the simpler patch to allow the test cases pass unless
someone can go through all the possible channel list update sequences in
more detail.
> This is general question:
> how should we handle events when ifidx==-1 and wdev_id is not set.
Which events are these (other than the channel list change indication)?
--
Jouni Malinen PGP id EFC895FA
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
