> -----Original Message----- > From: Jouni Malinen [mailto:j@xxxxx] > Sent: Tuesday, March 08, 2016 11:02 > To: Johannes Berg > Cc: Peer, Ilan; hostap@xxxxxxxxxxxxxxxxxxx > Subject: Re: [RFC 4/4] tests: Modify test_hs20_filter > > On Tue, Mar 08, 2016 at 08:47:53AM +0100, Johannes Berg wrote: > > On Mon, 2016-03-07 at 18:55 +0200, Ilan Peer wrote: > > > Modify the test cases to tests the HS20 filtering functionality in > > > wpa_supplicant, instead of testing only the kernel interface. > > > > I wonder if we should keep both? But I guess it's wpa_supplicant > > tests, not kernel tests :) > > I'm fine with including test cases that are mainly targeting > cfg80211/mac80211 or related functionality, so if the previous test cases had > additional coverage that would not be verified when going through > wpa_supplicant to set the parameters, it would make sense to add new test > cases instead of replace the existing ones. > The patch removed the verification of the cases that the filters are not configured but I did not think that they are needed. If needed I can add tests cases that check that the frames are not filtered when they should not. Ilan. _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
