Re: [PATCH v5 15/25] wpa_cli: handle IFNAME correctly for global iface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7 March 2016 at 09:59, Jouni Malinen <j@xxxxx> wrote:
> On Sun, Mar 06, 2016 at 12:00:50PM +0100, Janusz Dziedzic wrote:
>> On 5 March 2016 at 15:33, Jouni Malinen <j@xxxxx> wrote:
>> > On Fri, Mar 04, 2016 at 10:20:31AM +0100, Janusz Dziedzic wrote:
>> >> In case we are using wpa_cli to connect global UDP
>> >> interface, before we have "UNKNOWN COMMAND\n" string
>> >> as ifname. Change this to "unknown".
>> >
>> > Why would "unknown" be any better than "UNKNOWN COMMAND\n"? "unknown"
>> > would be a valid name of an interface. If we want to changes "UNKNOWN
>> > COMMAND\n" to something, that something better be something that can be
>> > clearly identified as not being a network interface.
>> >
>> No idea here, added this because of "cosmetic" purpose. So, maybe skip
>> this one or just remove "\n"?
>
> Why would "\n" be removed? I don't really understand what is the point
> of this change in the first place. What is this needed for?
>
When using wpa_cli with UDP support we have nice prompt:

hostname/wlan0>

wlan0 is a result of "IFNAME", so for global iface we see:

localhost/UNKNOWN COMMAND
>

BR
Janusz

> --
> Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux