On Fri, Mar 04, 2016 at 10:20:26AM +0100, Janusz Dziedzic wrote: > Setup ctrl_interface name. This should be used > to check interface <-> udp port assigment. > diff --git a/wpa_supplicant/ctrl_iface_udp.c b/wpa_supplicant/ctrl_iface_udp.c > @@ -380,10 +381,8 @@ wpa_supplicant_ctrl_iface_init(struct wpa_supplicant *wpa_s) > priv->sock = -1; > os_get_random(priv->cookie, COOKIE_LEN); > > - if (wpa_s->conf->ctrl_interface == NULL) > - return priv; > - > - pos = os_strstr(wpa_s->conf->ctrl_interface, "udp:"); > + if (wpa_s->conf->ctrl_interface) > + pos = os_strstr(wpa_s->conf->ctrl_interface, "udp:"); Could you please clarify what this is trying to do? This would end up opening the control interface socket even if the configuration has the control interface disabled (wpa_s->conf->ctrl_interface == NULL). That does not sound correct and the commit message is not very clear on the purpose of this change. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
