Re: [PATCH 15/25] WNM: Add candidate list to BSS transition response

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 22, 2016 at 09:35:18AM +0000, Peer, Ilan wrote:
> > Why is that conversion from vht_oper->vht_op_info_chwidth to vht used
> > here when the Channel Width field in the VHT Operation element is using
> > those VHT_CHANWIDTH_* values? The values 2, 3, and 4 here do not match
> > the values used in this field and the correct thing to do would seem to be
> > simply to set vht = vht_oper->vht_op_info_chwidth.
> > 
> 
> This is indeed wrong. I think that we got this confused with the values defined in Table 8-151 (HT/VHT Operation Information subfields) as defined in P802.11REVmc D4.3.
> 
> Shall I resubmit this patch with the fixes?

No need, I've already fixed it. I think I'm now mostly done with the
review and cleanup of this series. The current snapshot is in the
pending branch of hostap.git. Please let me know if you happen to notice
something odd there; otherwise, I'm likely to push these into the master
branch later today.

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux