Re: [PATCH v3 12/26] wpa_supplicant: udp ctrl show when ITERFACES cmd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 17, 2016 at 01:14:15PM +0100, Janusz Dziedzic wrote:
> Show udp port when handle INTERFACES command.

> diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c
> @@ -9233,7 +9233,12 @@ static int wpa_supplicant_global_iface_interfaces(struct wpa_global *global,
> +#ifdef CONFIG_CTRL_IFACE_UDP
> +		res = os_snprintf(pos, end - pos, "%s ctrl_iface=%s\n",
> +				  wpa_s->ifname, wpa_s->conf->ctrl_interface);
> +#else
>  		res = os_snprintf(pos, end - pos, "%s\n", wpa_s->ifname);
> +#endif

Wouldn't this break all existing expectations on INTERFACES command
output format? It does not look good to return different values based on
which control interface backend is used.

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux