Re: [PATCH] Remove duplicated center_freq init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 16, 2016 at 11:16:09AM +0100, eabinader@xxxxxxxxx wrote:
> As the center freq values are adjusted in a proper
> function, dfs_adjust_vht_center_freq, just ensure
> there is no duplicated code for that.

Could you please clarify where these values are set in all possible code
paths? As far as I can tell, there are possible cases where it is far
from obvious that these get initialized. As such, I'd much rather leave
these here in dfs_get_valid_channel() to avoid getting uninitialized
values. It looks like much less work to do what is done currently rather
than go through each possible code path and add similar clearing to
places where it may be currently missing.
 
-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux