Re: [Projekt-wlan] [PATCHv3 00/12] Tagged VLAN and per_sta_vif support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Am 08.02.2016 um 18:29 schrieb Jouni Malinen:
> That patch seems to break hostapd for number of hwsim test cases, e.g.,
> ap_vlan_wpa2_radius. The hostapd process seems to end up in some kind of
> busy loop when processing Access-Accept and that makes it very difficult
> to run any hwsim testing.

I think the issue is introduced by following change you made to
radius_msg_get_vlanid:

>-       for (i = 0; i < numtagged; i++)
>-               tagged[i] = 0;
>+       for (j = 0; j < numtagged; i++)
>+               tagged[j] = 0;

The loop variable is not incremented (i instead of j).

The attached change fixes ap_vlan_wpa2_radius for me.

Shall I resent the full fixed series?

Regards,
M. Braun
diff --git a/src/radius/radius.c b/src/radius/radius.c
index 8bc7c0f..ca2925d 100644
--- a/src/radius/radius.c
+++ b/src/radius/radius.c
@@ -1447,7 +1447,7 @@ int radius_msg_get_vlanid(struct radius_msg *msg, int *untagged, int numtagged,
        int taggedidx = 0, vlan_id;
 
        os_memset(&tunnel, 0, sizeof(tunnel));
-       for (j = 0; j < numtagged; i++)
+       for (j = 0; j < numtagged; j++)
                tagged[j] = 0;
        *untagged = 0;
 
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap

[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux