On Sun, Dec 27, 2015 at 02:36:11PM +0200, Ilan Peer wrote: > As a dedicated P2P Device interface does not have a network > interface associated with it, trying to call linux_iface_up() > on it would always fail so this call can be skipped for > such an interface. > > Getting interface nlmode can be done only after bss->wdev_id is > set, so move this call to wpa_driver_nl80211_finish_drv_init(), > and do it only in case the nlmode != NL80211_IFTYPE_P2P_DEVICE. Does this need to be done after the wpa_driver_nl80211_capa() call here? > @@ -2243,6 +2240,11 @@ wpa_driver_nl80211_finish_drv_init(struct wpa_driver_nl80211_data *drv, > if (wpa_driver_nl80211_capa(drv)) > return -1; > > + if (first && > + nl80211_get_ifmode(bss) != NL80211_IFTYPE_P2P_DEVICE && > + linux_iface_up(drv->global->ioctl_sock, bss->ifname) > 0) > + drv->start_iface_up = 1; The sequence used here would be different for fetching driver capabilities compared to what was used previously (i.e., the interface would now be down while it was up previously). I'd rather avoid such a change here (i.e., reorder these two calls with wpa_driver_nl80211_finish_drv_init()) unless this nl80211_get_ifmode() part is not expected to work here without the driver capabilities fetched. If this specific sequence is needed, I'd like to get better understand on whether this could break any existing use cases (i.e., whether there is a driver that cannot return correct capabilities without the interface being UP first). If I understood correctly, this new patch does not really fix anything other than maybe making the debug log cleaner (and well, if it does fix something, the commit log should be modified to say so). -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
