HostAP, accounting Stop, and input/output octets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 I've had a report that HostAP doesn't send Acct-Input-Octets / Acct-Output-Octets in Accounting-Request packets with Acct-Status-Type = Stop.

 Some spelunking through the code leads me to believe that this is likely.  src/ap/accounting.c has:

static void accounting_sta_report(struct hostapd_data *hapd,
				  struct sta_info *sta, int stop)
...

	if (accounting_sta_update_stats(hapd, sta, &data) == 0) {
		... add octet counters

	}

 The accounting_sta_update_stats() function returns -1 if hostapd_drv_read_sta_data() fails.

 What would be better is if it sent the last stats even if that function failed.  Patch is attached.  90% of the change is indentation.

 Alan DeKok.


Attachment: 0001-Always-send-the-last-stats-we-had-even-if-we-can-t-g.patch
Description: Binary data

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap

[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux