On Mon, Nov 2, 2015 at 8:40 PM, Chaitanya T K <chaitanya.mgit@xxxxxxxxx> wrote:
> From: tkc <chaitanya.mgit@xxxxxxxxx>
>
> Before the tx_status is received for the action frame, if we
> get another request, we respond to that by freeing the memory
> for pending_action_tx, but we don't cancel the TX wait, so
> in the kernel the ROC will not be cancelled.
>
> Due to above issue, wpa_supplicant assumes that all pending
> RoC's are cancelled and proceeds with interface creation and
> connection, where as state in mac80211/driver will be roc_in_progress.
>
> This is leading to issues at driver level.
>
> Signed-off-by: Chaitanya T K <chaitanya.mgit@xxxxxxxxx>
> ---
> V2: Fix 2 from's.
> Remove the unnecessary braces.
> ---
> wpa_supplicant/offchannel.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/wpa_supplicant/offchannel.c b/wpa_supplicant/offchannel.c
> index 6b3f83c..581c5f6 100644
> --- a/wpa_supplicant/offchannel.c
> +++ b/wpa_supplicant/offchannel.c
> @@ -253,15 +253,9 @@ int offchannel_send_action(struct wpa_supplicant *wpa_s, unsigned int freq,
>
> wpa_s->pending_action_tx_status_cb = tx_cb;
>
> - if (wpa_s->pending_action_tx) {
> - wpa_printf(MSG_DEBUG, "Off-channel: Dropped pending Action "
> - "frame TX to " MACSTR " (pending_action_tx=%p)",
> - MAC2STR(wpa_s->pending_action_dst),
> - wpa_s->pending_action_tx);
I think we should retain this print to identify if its a proper complete
or dropping pending. Anyways will wait for comments before sending V3.
.
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
