On Tue, Nov 03, 2015 at 06:29:12PM +0530, Somdas Bandyopadhyay wrote: > I agree that if the user saves his/her option then the pop up will > not be shown. PFA the patch that can be used to give the option to the > user for selecting his/her browser. One thing is for sure that we > should not be always launching the native android browser as it is not > present in most of the devices. I would anyways prefer that we > directly launch the chrome browser (patch submitted earlier in the > thread), instead of showing a pop up to the user for selecting the > browser. In general, I'm not sure I'd really recommend use of the default browser for Hotspot 2.0 OSU purposes on any platforms, i.e., I'd much rather use something similar to browser-wpadebug.c than browser-android.c. Obviously, wpabebug is unlikely to be the best choice for such an app, but it is an example that shows how simple it is to implement the needed functionality. The main benefits of using a custom app instead of default browser are both in usability (clean bring up of the web browser and robust way of closing it (that "input keyevent KEYCODE_HOME" is for the default browser is far from optimal) and in security (maintain separate context that does not share cookies or other stored values with the main browser). It should be noted that the URL for the Hotspot 2.0 use cases comes from an external device and it is not exactly good to accept any random URL and launch it in a web browser that is used for most of the normal web site browsing on the device. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
