On 02/04/2010 06:30 AM, Colin McCabe wrote:
Signed-off-by: Colin McCabe<cmccabe@xxxxxxxxxxxxxx> --- .gitignore | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
While patch #1 seems OK at first glance, patches 2 and 3 definitely belong in the big XDR patch, because they refer to things not yet in the tree.
Cosmetic patches breaking lines or moving code around are fine, in preparation for an upcoming patch. Those can be thought of as logically separate from the big XDR patch, even if they are -preparing- for said patch. For example, I am thinking that the next move might be to move existing code into smaller functions as you did -- ie. accept_seqid() -- while still keeping the existing, pre-XDR code logic. That makes the diff smaller, easier to read and review, while not specifically doing anything XDR related.
Jeff -- To unsubscribe from this list: send the line "unsubscribe hail-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
