Re: [PATCH] cld: use XDR for all messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/13/2010 04:38 PM, Pete Zaitcev wrote:
On Wed, 13 Jan 2010 16:03:45 -0500
Jeff Garzik<jeff@xxxxxxxxxx>  wrote:

Well, this definitely does not build as-is.  lib/Makefile.am needs

	BUILT_SOURCES           = cld_msg_rpc.h

otherwise nothing builds at all, because cld_msg_rpc.h does not exist.
test/Makefile.am and tools/Makefile.am both need

	-I$(top_srcdir)/lib

added to their INCLUDES. []

Kernel places generated files into the top include directory,
e.g. autoconf.h and asm-offsets.h for asm/. It's probably easier
than piling up include paths. I dunno.

Anything other than $(top_srcdir)/include requires an addition to INCLUDES. (remember, build-dir != src-dir always, especially with 'make distcheck')

Speaking of 'make distcheck', that is broken in the XDR patch, too. include/Makefile.am needs cld_fmt.h added to include_HEADERS.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe hail-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Fedora Clound]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux