Re: [PATCH 1/8 v3] cld: Declare common.c functions in common.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/14/2009 07:32 PM, Colin McCabe wrote:
Signed-off-by: Colin McCabe<cmccabe@xxxxxxxxxxxxxx>

applied, after fixing two problems:

* did not survive 'make distcheck'. common.h was needed in include/Makefile.am.
* introduced build warnings in the server.  added #include in server/cld.h.

Each patch should be internally consistent, and needs to survive 'make distcheck' and not introduce new build warnings (or errors!).

I also renamed common.h to cld_common.h, but that is a matter of taste, not a problem with your patch :)

--
To unsubscribe from this list: send the line "unsubscribe hail-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Fedora Clound]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux