On Tue, Dec 8, 2009 at 10:13 AM, Pete Zaitcev <zaitcev@xxxxxxxxxx> wrote: > On Mon, 7 Dec 2009 16:43:02 -0800 > Colin McCabe <cmccabe@xxxxxxxxxxxxxx> wrote: > >> +++ b/server/cld.h >> @@ -26,6 +26,7 @@ >> #include <glib.h> >> #include "cldb.h" >> #include <cld_msg.h> >> +#include "common.h" >> #include <libtimer.h> > > This should be <common.h> since it's common (in include). Sure > >> -extern int debugging; >> +extern struct cld_log srv_log; > >> - applog(LOG_INFO, "databases down"); >> + CLD_INFO(&srv_log, "databases down"); > > Great, you took code that was common across Hail and made it specific > to CLD again. I guess I could name the log messages HAIL_INFO, etc. I don't know if that would be an improvement or not. Colin > > -- Pete > -- > To unsubscribe from this list: send the line "unsubscribe hail-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe hail-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
