Re: [PATCH v2 2/2] cld: read the cld.port file using g_file_get_contents

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 28 Nov 2009 16:23:29 -0500
Jeff Garzik <jeff@xxxxxxxxxx> wrote:

> > +++ cld-tip/server/server.c
> > @@ -722,7 +741,7 @@ static int net_open_any(void)
> >
> >   	if (cld_srv.port_file) {
> >   		char portstr[7];
> > -		snprintf(portstr, sizeof(portstr), "%u\n", port);
> > +		snprintf(portstr, sizeof(portstr), "%u", port);
> >   		return net_write_port(cld_srv.port_file, portstr);
> >   	}
> >   	return 0;
> >
> > Our PID files contain a linefeed, as a courtesy to those who
> > examine them from a shell. But CLD's contains two.

> Agreed... wanna wrap that in a signed-off-by?  :)

Sure, I can do it. Although, it was intended as a hint for Colin
about the kind of bugs we have scattered all over (probably).
This one was harmless.

-- pete
--
To unsubscribe from this list: send the line "unsubscribe hail-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Fedora Clound]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux