Re: [PATCH] Some minor CLD test program fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/27/2009 06:20 PM, cmccabe@xxxxxxxxxxxxxx wrote:
From: cmccabe<cmccabe@xxxxxxxxxxxxxx>

Hi all! Here is a small patch to the CLD test programs...

When doing a raw read(2) in cld_readport(), resume after EINTR. Also resume if
we read less than the requested amount.

In the test programs, call g_thread_init() before cldc_init(). cldc_init has a
stern warning to "call cldc_init after g_thread_init, if present."
---
  lib/common.c           |   37 ++++++++++++++++++++++++++++++++++---
  test/it-works.c        |    1 +
  test/load-file-event.c |    1 +
  test/lock-file-event.c |    1 +
  test/save-file-event.c |    1 +
  5 files changed, 38 insertions(+), 3 deletions(-)

Oh, and two procedural notes:

1) As noted in doc/contributions.txt (and like the Linux kernel), all patches must include a Signed-off-by line. This normally is the last line in the extended patch description, found in the email body.

2) Adding "From: ..." is rather pointless in this case, because the From: feature is used to denote an author other than yourself. The default is taken from the email RFC822 headers, which appear to be fine in your case. In the kernel, Andrew Morton uses this feature to indicate the original patch author, when he mails a huge swath of patches to Linus for application.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe hail-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Fedora Clound]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux