On Sat, 14 Nov 2009 18:44:26 -0500, Jeff Garzik <jeff@xxxxxxxxxx> wrote: > 1) What is the point of db->del() in rep_add_nid() ? You are in the > middle of a transaction, and you immediately overwrite that record in > the same transaction. That is clearly unnecessary work, when db->put() > will simply overwrite an existing record, if requested. That didn't work last I tested, but I forgot what the issue was. The code is copied from object.c. I'll review it. > 2) rep_scan(): I would rather not make the entire daemon non-responsive > for multiple seconds. > > The database is already in multi-threaded mode, and db4 is > free-threaded, so it would seem to make a lot more sense to simply > g_thread_create() a thread to do this work. True, but multi-threading in tabled is a much bigger undertaking than just "simply" creating a thread. There's a lot of common state. I think the 2s problem is less urgent than processing massive replication more efficiently (from a Chunk down). > Also, there should be no need to scan a chunkd's keys at all, as long as > the chunkd instance is still communicating with us. No, there's a need, although there's no code for it: the scan should probe keys by requesting their metadata, which forturously includes checksums. This is how the results of Chunk's self-test will be communicated to tabled. -- Pete -- To unsubscribe from this list: send the line "unsubscribe hail-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
