A thought just occured to me that it's dumb to expand the message itself when you can expand the format. This way all the potentially long things like CLD pathnames do not count against your stack and there's essentially no chance to get any messages truncated. The first snprintf is actually a strncat, but it's more concise. Signed-off-by: Pete Zaitcev <zaitcev@xxxxxxxxxx> diff --git a/tools/cldcli.c b/tools/cldcli.c index eb4ebc4..60ab301 100644 --- a/tools/cldcli.c +++ b/tools/cldcli.c @@ -131,8 +131,8 @@ static void applog(int prio, const char *fmt, ...) va_list ap; va_start(ap, fmt); - vsnprintf(buf, 200, fmt, ap); - fprintf(stderr, "%s\n", buf); + snprintf(buf, 200, "%s\n", fmt); + vfprintf(stderr, buf, ap); va_end(ap); } -- To unsubscribe from this list: send the line "unsubscribe hail-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
