Hello Tim, -----Original Message----- From: gstreamer-embedded-bounces+pprakash=ti.com at lists.freedesktop.org [mailto:gstreamer-embedded-bounces+pprakash=ti.com at lists.freedesktop.org] On Behalf Of Tim-Philipp M?ller Sent: Friday, November 04, 2011 7:51 PM To: gstreamer-embedded at lists.freedesktop.org Subject: Re: [PATCH] gstfbdevsink: Fix depth value for GST_VIDEO_CAPS_RGB_15 On Fri, 2011-11-04 at 13:13 -0500, Punya Prakash wrote: Hi, > RGB color format does not have any alpha components, adding alpha length to depth could yield wrong results. > > Signed-off-by: Punya Prakash <pprakash at ti.com> > --- > sys/fbdev/gstfbdevsink.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/sys/fbdev/gstfbdevsink.c b/sys/fbdev/gstfbdevsink.c > index 8925f3d..568f091 100644 > --- a/sys/fbdev/gstfbdevsink.c > +++ b/sys/fbdev/gstfbdevsink.c > @@ -185,8 +185,7 @@ gst_fbdevsink_getcaps (GstBaseSink * bsink) > "bpp", G_TYPE_INT, fbdevsink->varinfo.bits_per_pixel, > "depth", G_TYPE_INT, fbdevsink->varinfo.red.length + > fbdevsink->varinfo.green.length + > - fbdevsink->varinfo.blue.length + > - fbdevsink->varinfo.transp.length, > + fbdevsink->varinfo.blue.length, > "endianness", G_TYPE_INT, endianness, > "red_mask", G_TYPE_INT, rmask, > "green_mask", G_TYPE_INT, gmask, "blue_mask", G_TYPE_INT, bmask, NULL); Thanks for the patch, but could you please put it as git format-patch style patch into bugzilla (or ping the bug if there is one already)? Thanks! Thank you for your feedback. This is a git-format patch, I have now filed a bug with the patch. Bug ID: 663574. Regards, Punya Cheers -Tim _______________________________________________ gstreamer-embedded mailing list gstreamer-embedded at lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/gstreamer-embedded
