Re: [PATCH] staging: greybus: Fix capitalization and punctuation inconsistencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 01, 2024 at 05:18:59PM -0400, Steven Davis wrote:
> There were a lot of inconsistencies in outputs and
> comments, some were properly formatted and
> capitalized, and some weren't. This patch resolves
> this by properly formatting the inconsistent comments
> and outputs.
> 
> Signed-off-by: Steven Davis <goldside000@xxxxxxxxxxx>
> ---
>  drivers/staging/greybus/arche-platform.c | 38 ++++++++++++------------
>  drivers/staging/greybus/authentication.c |  6 ++--
>  drivers/staging/greybus/bootrom.c        | 16 +++++-----
>  drivers/staging/greybus/light.c          | 26 ++++++++--------
>  drivers/staging/greybus/log.c            | 10 +++----
>  5 files changed, 48 insertions(+), 48 deletions(-)

I didn't have time to reply here before Greg picked this one up, but I'm
gonna ask for this one to be reverted.

The (core) greybus code uses lower case error messages so this patch is
introducing an inconsistency instead of addressing one.

I just sent a revert here:

	https://lore.kernel.org/20240909124853.9213-1-johan@xxxxxxxxxx

Johan
_______________________________________________
greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx



[Index of Archives]     [Asterisk App Development]     [PJ SIP]     [Gnu Gatekeeper]     [IETF Sipping]     [Info Cyrus]     [ALSA User]     [Fedora Linux Users]     [Linux SCTP]     [DCCP]     [Gimp]     [Yosemite News]     [Deep Creek Hot Springs]     [Yosemite Campsites]     [ISDN Cause Codes]     [Asterisk Books]

  Powered by Linux