Re: [PATCH] staging: greybus: Enclose multi-statement macro in do-while loop

[Juan José <soyjuanarbol@xxxxxxxxx>]

Yes! I build and clean and build and clean and build again, everything seems fine from the compiler side and posttest task as well. Everything seems ok.

Thanks,

- Juan José

On Wed, Jul 17, 2024 at 2:50 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

On Wed, Jul 17, 2024 at 01:58:34AM -0500, Juan José Arboleda wrote:
> The macro `gb_loopback_stats_attrs` in the Greybus loopback driver
> contains multiple statements, which should be enclosed in a do-while
> loop to ensure proper execution and adhere to coding standards.
>
> This patch modifies the `gb_loopback_stats_attrs` macro to enclose
> its statements in a do-while loop, addressing the style error flagged
> by checkpatch.pl.
>
> Signed-off-by: Juan José Arboleda <soyjuanarbol@xxxxxxxxx>
> ---
>  drivers/staging/greybus/loopback.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index 4313d3bbc23a..a97de86c67a5 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -163,9 +163,11 @@ static ssize_t name##_avg_show(struct device *dev,               \
>  static DEVICE_ATTR_RO(name##_avg)
> 
>  #define gb_loopback_stats_attrs(field)                               \
> -     gb_loopback_ro_stats_attr(field, min, u);               \
> -     gb_loopback_ro_stats_attr(field, max, u);               \
> -     gb_loopback_ro_avg_attr(field)
> +     do {                                                    \
> +             gb_loopback_ro_stats_attr(field, min, u);       \
> +             gb_loopback_ro_stats_attr(field, max, u);       \
> +             gb_loopback_ro_avg_attr(field);                 \
> +     } while (0)
> 
>  #define gb_loopback_attr(field, type)                                        \
>  static ssize_t field##_show(struct device *dev,                              \

Are you sure you test-built this change?

thanks,

greg k-h

--

Regards,

-Juan José

_______________________________________________
greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx