On 3/19/24 11:02, Krzysztof Kozlowski wrote:
On 16/03/2024 14:06, Ayush Singh wrote:> Are you sure this fits in Linux coding style limit (not checkpatch limit, but the limit expressed by Linux coding style)? Well, I am just using clang-format with column width of 100 instead of 80. The docs now say 80 is prefered rather than mandatory, so well I wasSo you introduce your own style? Then consider it mandatory...using 100 since I prefer that. If 80 is necessary or would make review easier than I can just switch to it.You do not choose your own coding style.I will remove serdev, pwm, clickID and send a new patch with the minimal driver and better commit messages as suggested with Vaishnav. It is important to have good support for mikroBUS boards without clickID as well.Best regards, Krzysztof
I mean after the whole discussion about 80 vs 100 column line limit a few years ago, and change in checkpatch behavior, I thought 100 was an acceptable column length in the kernel, but I guess was mistaken, and 80 character is still mandatory? Not sure why there was a change in checkpatch and docs though.
Regardless, I have switched 80 in the next patch since it is mandatory, and I do not care as long as I can format using a formatter.
Ayush Singh _______________________________________________ greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
|