Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Ayush Singh <ayushdevel1325@xxxxxxxxx>, Vaishnav M A <vaishnav@xxxxxxxxxxxxxxx>, devicetree@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, lorforlinux@xxxxxxxxxxxxxxx, greybus-dev@xxxxxxxxxxxxxxxx
- Subject: Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver
- From: Markus Elfring <Markus.Elfring@xxxxxx>
- Date: Mon, 18 Mar 2024 19:12:21 +0100
- In-reply-to: <20240317193714.403132-5-ayushdevel1325@gmail.com>
- References: <20240317193714.403132-5-ayushdevel1325@gmail.com>
- Ui-outboundreport: notjunk:1;M01:P0:FOAv7gLOqbk=;LIFw7TE+o2L/aes12HD1LR9Y1I0 VDIjhJs70jys6vXqjVzsgrWtqrEk9pchL9A+mGrUuU99U2rzuYEvJe3Tp0/WZpfS7FCgkZt6n wf4MuB3QnaDd3jyAg6wfQFcWpPpzY2mJUXIsFtteJWmXX8LxUf84i6opANHArV6uPrTgW1Bt8 ye49vSH5h8mLrS5Egj+E7vN+eTIpzd3pr0XqiOjpEvUeXtGjj/AD53pnNayTJy8s8PsfW9/+Q 8amXd2uh1sYJX6GK1MqiJHlaRy33xCM69nyFSCNOqHzFCbrR1BqGddY7yKRALti7PUmdUTe7p 5Q5I2FcCXUoI6HQburx4jGu1ftlbnqcpp/0FdKovJI95vXuxYf7RIuDad8S5vz0Yyt84Rb8Wr G/tGX7Qvs6dgatLzJlUQLjfJ3jd/wzjfB1j3QFpAiIuef8TUmvokOgPESnwR96E7H2c/Ul6j+ q7BB1qJD1+B+GF4520sj1KEIsePWDJrlvGb/DRgyYkHBxAFHmIfEPfxR8YVHQMw+U3FvWMLcv mnxV4xtKtb/7cklHsq3MY09j55UNMdKEhngLtNn8Ua1Ion3GAWEqv4tA1+bL07hm6nCfinpeU tIA/Z3AFQMJ/LM+kKDJZQd8PmaZCY52VMv5YnxybipwTuwOK3E3DuJHYQH9btP8v7746qxjuH 2C/xWUSp6SGrPueZ+BvTReM5nrolHLfNQUl9cMU9gCl9buwICLJYiuQtu+jDn6QKiBDkyrife Lj0OzKfxvNPeK8h2fp+zxep8H/B417sLSJpY4Fy1zJIr+jNxaiAsSgLeoOjgpFRQZHylw4n6o e1HDP836GHMfIfjaEKUq9QklADBV+IztnZKY+buyRd+Bs=
- User-agent: Mozilla Thunderbird
…
> +++ b/drivers/misc/mikrobus/mikrobus_core.h
…
> +#ifndef __MIKROBUS_H
> +#define __MIKROBUS_H
…
I suggest to avoid the specification of leading underscores for include guards.
See also:
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29
Regards,
Markus
_______________________________________________
greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
[Index of Archives]
[Asterisk App Development]
[PJ SIP]
[Gnu Gatekeeper]
[IETF Sipping]
[Info Cyrus]
[ALSA User]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite News]
[Deep Creek Hot Springs]
[Yosemite Campsites]
[ISDN Cause Codes]
[Asterisk Books]
