On 09:40-20231006, Ayush Singh wrote:
> Add DT bindings for Texas Instruments Simplelink CC1352P7 wireless MCU
>
> BeaglePlay has CC1352P7 co-processor connected to the main AM62 (running
> Linux) over UART. In the BeagleConnect Technology, CC1352 is responsible
> for handling 6LoWPAN communication with beagleconnect freedom nodes as
> well as their discovery.
>
> Signed-off-by: Ayush Singh <ayushdevel1325@xxxxxxxxx>
> ---
very minor comments follow:
> .../devicetree/bindings/net/ti,cc1352p7.yaml | 51 +++++++++++++++++++
> MAINTAINERS | 6 +++
> 2 files changed, 57 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> new file mode 100644
> index 000000000000..742763e04543
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/ti,cc1352p7.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Simplelink CC1352P7 wireless MCU
> +
> +description:
> + The cc1352p7 mcu can be connected via SPI or UART.
s/cc1352p7/CC1352P7
s/mcu/MCU
> +
> +maintainers:
> + - Ayush Singh <ayushdevel1325@xxxxxxxxx>
> +
> +properties:
> + compatible:
> + const: ti,cc1352p7
> +
> + clocks:
> + items:
> + - description: main system (mcu and peripherals) clock
s/mcu/MCU
also I'd call it high-frequency clock to give explanation of what "hf"
means.
> + - description: low-frequency system clock
> +
> + clock-names:
> + items:
> + - const: sclk_hf
> + - const: sclk_lf
> +
> + reset-gpios:
> + maxItems: 1
> +
> + vdds-supply: true
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + serial {
> + mcu {
> + compatible = "ti,cc1352p7";
> + clocks = <&sclk_hf 0>, <&sclk_lf 25>;
> + clock-names = "sclk_hf", "sclk_lf";
> + reset-gpios = <&pio 35 GPIO_ACTIVE_LOW>;
> + vdds-supply = <&vdds>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 37b9626ee654..5467669d7963 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8969,6 +8969,12 @@ F: drivers/staging/greybus/sdio.c
> F: drivers/staging/greybus/spi.c
> F: drivers/staging/greybus/spilib.c
>
> +GREYBUS BEAGLEPLAY DRIVERS
> +M: Ayush Singh <ayushdevel1325@xxxxxxxxx>
> +L: greybus-dev@xxxxxxxxxxxxxxxx (moderated for non-subscribers)
> +S: Maintained
> +F: Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> +
> GREYBUS SUBSYSTEM
> M: Johan Hovold <johan@xxxxxxxxxx>
> M: Alex Elder <elder@xxxxxxxxxx>
> --
> 2.41.0
>
With those minor comments (if there is a need for a respin):
Reviewed-by: Nishanth Menon <nm@xxxxxx>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
|