Re: [PATCH 2/2] staging/greybus: Add BeaglePlay Linux Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 8/30/23 17:58, Greg KH wrote:

On Wed, Aug 30, 2023 at 05:54:27PM +0530, Ayush Singh wrote:
This is Serdev driver that communicates with Greybus SVC connected over
UART. This driver has only been tested on BeaglePlay (with CC1352 in
BeaglePlay serving as SVC).

This driver is responsible for the following:
- Start SVC (CC1352) on driver load.
- Send/Receive Greybus messages to/from CC1352 using HDLC over UART.
- Print Logs from CC1352.
- Stop SVC (CC1352) on driver load.

This patch does the following:
- Add Driver
- Add Kconfig option to enable the driver
- Update Makefile to build the driver

Signed-off-by: Ayush Singh <ayushdevel1325@xxxxxxxxx>
  MAINTAINERS                             |   5 +
  drivers/staging/greybus/Kconfig         |   9 +
  drivers/staging/greybus/Makefile        |   3 +
  drivers/staging/greybus/gb-beagleplay.c | 493 ++++++++++++++++++++++++
Why is this in drivers/staging/ and not in drivers/greybus/ ?

Well, there are a few reasons I can give:

1. It has not been thoroughly tested. I have only tested it in my personal setup.

2. Since mikrobus code has not been merged, running a normal beagleconnect freedom as the greybus node is not possible.

3. I thought new and experimental drivers should go into staging?

Sorry for the checkpatch error. I added the copyright after running checkpatch and forgot to run it again.

greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx

[Index of Archives]     [Asterisk App Development]     [PJ SIP]     [Gnu Gatekeeper]     [IETF Sipping]     [Info Cyrus]     [ALSA User]     [Fedora Linux Users]     [Linux SCTP]     [DCCP]     [Gimp]     [Yosemite News]     [Deep Creek Hot Springs]     [Yosemite Campsites]     [ISDN Cause Codes]     [Asterisk Books]

  Powered by Linux