Khadija Kamran wrote: > On Sun, Apr 02, 2023 at 05:37:48PM -0700, Ira Weiny wrote: > > Khadija Kamran wrote: > > > arche_platform_wd_irq() function has two exit paths. To make the code > > > more readable, use only one exit path. > > > > > > Suggested-by: Alison Schofield <alison.schofield@xxxxxxxxx> > > > > Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx> > > > > Okay, noted. > > Also, would it be okay to send a patch revision with the changes or > should I wait for the feedback on Dan's comment. Here is a link to it: > https://lore.kernel.org/outreachy/6ce8aa34-e600-4d6a-adad-ead8255342e5@kili.mountain/ In this case you are going to need to make a v2 of the _series_. In the next revision you send both patches again as V2. (If you are using b4[*] it will help to track the series versions.) I am saying this patch looks good but there are still issues with patch 2/2. If there are no other comments on 1/2 and you don't make any changes then you include it with my review tag as v2. When I do this I make a note of picking up tags like so: --- Changes from V1: Add review tags If you get other comments and make changes then my review is no longer valid because you have changed the patch. In that case make those changes and make a note. Then I can see why my review was dropped and, more importantly, I know why I should look at the patch again. Then in patch 2/2 make changes as needed. Ira [*] https://b4.docs.kernel.org/en/latest/ _______________________________________________ greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
|