On Mon, Mar 20, 2023 at 05:33:44PM -0700, Ira Weiny wrote: > Khadija Kamran wrote: > > On Sun, Mar 12, 2023 at 06:01:03PM -0700, Ira Weiny wrote: > > > Khadija Kamran wrote: > > > > In file drivers/staging/greybus/arche-platform.c, > > > > - Length of line 181 exceeds 100 columns, fix by removing tabs from the > > > > line. > > > > - If condition and spin_unlock_...() call is split into two lines, join > > > > them to form a single line. > > > > > > > > Signed-off-by: Khadija Kamran <kamrankhadijadj@xxxxxxxxx> > > > > > > Fundamentally the problem with arche_platform_wd_irq() is that the > > > indentation is too great. > > > > > > "... if you need more than 3 levels of indentation, you’re screwed anyway, > > > and should fix your program." > > > > > > -- https://www.kernel.org/doc/html/v4.10/process/coding-style.html#indentation > > > > > > I think a better solution would be to refactor the entire function. This > > > would make the logic of the function more clear as well IMHO. > > > > > > Here is another tip to help: > > > > > > https://www.kernel.org/doc/html/v4.10/process/coding-style.html#centralized-exiting-of-functions > > > > > > Do you think you could try that? > > > > Hey Ira! > > > > Sorry about the late reply. Thank you for your feedback. I have looked > > into the above link. Are you referring to the use of goto statements in > > arche_platform_wd_irq() call? > > I'm not quite sure I understand what you mean because currently > arche_platform_wd_irq() does not use gotos. > > But I think you are asking if I think it should. If that is what you mean > then 'yes' I think arche_platform_wd_irq() could use goto's to clean up > the flow. > Hey Ira, Yes, I am asking if I should use goto's. Thank you for the reply. Let me get back to you after making the changes. Regards, Khadija > Ira _______________________________________________ greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
|