Re: [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On ١١‏/٣‏/٢٠٢٣ ١٦:٣٨, Julia Lawall wrote:

On Sat, 11 Mar 2023, Menna Mahmoud wrote:

On ١١/٣/٢٠٢٣ ١٤:٥٧, Menna Mahmoud wrote:
On ١١/٣/٢٠٢٣ ١٤:٥٥, Julia Lawall wrote:
On Sat, 11 Mar 2023, Menna Mahmoud wrote:

On ١١/٣/٢٠٢٣ ١٠:٥٩, Julia Lawall wrote:
On Fri, 10 Mar 2023, Menna Mahmoud wrote:

Fix " CHECK: Alignment should match open parenthesis "
Reported by checkpath
See the message in the other mail about the log message.

Also, you should not have two patches with the same subject.  Here,
changes are on the same file and are essentially the same, even
the same function call.  So they can be together in one patch.

okay, I will. appreciate your feedback. thanks.
Please put some blank lines around your response, so it is easier to find.


Okay, I will.



Hi Julia,

according to Alex feedback

" I think this type of alignment is not a major problem,
and alignment isn't done this way in general in this
driver, it's probably OK to keep it that way. - Alex "

,I won't resubmit these patches, right?
The existing code indeed looks better to me.  So you can skip this issue.


Okay, thanks Julia.


Signed-off-by: Menna Mahmoud <>
    drivers/staging/greybus/fw-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/fw-core.c
index 57bebf24636b..f562cb12d5ad 100644
--- a/drivers/staging/greybus/fw-core.c
+++ b/drivers/staging/greybus/fw-core.c
@@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle

                connection = gb_connection_create(bundle, cport_id,
-                        gb_fw_mgmt_request_handler);
                if (IS_ERR(connection)) {
                    ret = PTR_ERR(connection);

greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx

[Index of Archives]     [Asterisk App Development]     [PJ SIP]     [Gnu Gatekeeper]     [IETF Sipping]     [Info Cyrus]     [ALSA User]     [Fedora Linux Users]     [Linux SCTP]     [DCCP]     [Gimp]     [Yosemite News]     [Deep Creek Hot Springs]     [Yosemite Campsites]     [ISDN Cause Codes]     [Asterisk Books]

  Powered by Linux