On Sat, Mar 11, 2023 at 07:16:19AM +0300, Dan Carpenter wrote: > On Sat, Mar 11, 2023 at 03:18:04AM +0500, Khadija Kamran wrote: > > In file drivers/staging/greybus/arche-platform.c, > > - Length of line 181 exceeds 100 columns, fix by removing tabs from the > > line. > > - If condition and spin_unlock_...() call is split into two lines, join > > them to form a single line. > > > > Signed-off-by: Khadija Kamran <kamrankhadijadj@xxxxxxxxx> > > --- > > Changes in v2: > > - Change the subject and log message > > - Merge if condition and spin_unlock...() from two lines to one > > Apply your patch and then re-run checkpatch.pl -f on the file. You will > see the problem. Hey Dan! When I run checkpatch.pl on my file, I can see that my old CHECK no longer exists instead a new CHECK is mentioned saying 'Alignment should match open parenthesis'. I understand this from your previous email. Should I stop working on this file and leave it as is? Thank you! > > regards, > dan carpenter _______________________________________________ greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
|