Re: [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis

[Menna Mahmoud <eng.mennamahmoud.mm@xxxxxxxxx>]

On ١٠‏/٣‏/٢٠٢٣ ١٨:١٦, Alex Elder wrote:
> On 3/10/23 9:51 AM, Menna Mahmoud wrote:
> > Fix " CHECK: Alignment should match open parenthesis "
> > Reported by checkpath
> >
> > Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@xxxxxxxxx>
>
> Is this (and your second patch) the only place(s) where
> this issue gets reported?

> yes, after fixed them i got 0 check.

> I think this type of alignment is not a major problem,
> and alignment isn't done this way in general in this
> driver, it's probably OK to keep it that way.

Okay, thanks.

 -Menna

>                     -Alex
>
> > ---
> >   drivers/staging/greybus/fw-core.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/greybus/fw-core.c 
> > b/drivers/staging/greybus/fw-core.c
> > index 57bebf24636b..f562cb12d5ad 100644
> > --- a/drivers/staging/greybus/fw-core.c
> > +++ b/drivers/staging/greybus/fw-core.c
> > @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle,
> >               }
> >                 connection = gb_connection_create(bundle, cport_id,
> > -                        gb_fw_mgmt_request_handler);
> > +                              gb_fw_mgmt_request_handler);
> >               if (IS_ERR(connection)) {
> >                   ret = PTR_ERR(connection);
> >                   dev_err(&bundle->dev,
_______________________________________________
greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx