Re: [PATCH v3 2/2] staging: greybus: remove empty callback function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 4/12/22 11:38 PM, Jaehee Park wrote:
Remove the optional remove callback for the soc_codec_dev_gbaudio
structure. The only place it is referenced is
snd_soc_component_remove() which is only called if the sound_component
pointer is non-null. The null function pointers here can be optionally
ommitted. When a sound component is registered this way, the remove
callback is optional. We can safely remove the whole gbcodec_remove
function, which used to be an empty function with a void return type.

Now I think your description is a little long...  But that's OK.

This looks good to me.  Thank you for responding to all our

Reviewed-by: Alex Elder <elder@xxxxxxxxxx>

Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Signed-off-by: Jaehee Park <jhpark1013@xxxxxxxxx>
  drivers/staging/greybus/audio_codec.c | 8 --------
  1 file changed, 8 deletions(-)

diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index 0f50d1e51e2c..dc030caa64ba 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -1029,12 +1029,6 @@ static int gbcodec_probe(struct snd_soc_component *comp)
  	return 0;
-static void gbcodec_remove(struct snd_soc_component *comp)
-	/* Empty function for now */
-	return;
  static int gbcodec_write(struct snd_soc_component *comp, unsigned int reg,
  			 unsigned int value)
@@ -1049,8 +1043,6 @@ static unsigned int gbcodec_read(struct snd_soc_component *comp,
static const struct snd_soc_component_driver soc_codec_dev_gbaudio = {
  	.probe	= gbcodec_probe,
-	.remove	= gbcodec_remove,
  	.read = gbcodec_read,
  	.write = gbcodec_write,

greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx

[Index of Archives]     [Asterisk App Development]     [PJ SIP]     [Gnu Gatekeeper]     [IETF Sipping]     [Info Cyrus]     [ALSA User]     [Fedora Linux Users]     [Linux SCTP]     [DCCP]     [Gimp]     [Yosemite News]     [Deep Creek Hot Springs]     [Yosemite Campsites]     [ISDN Cause Codes]     [Asterisk Books]

  Powered by Linux